feat(ui): new ux for run model settings #1386
Conversation
Signed-off-by: Petr Kadlec <[email protected]>
Signed-off-by: Petr Kadlec <[email protected]>
Summary of ChangesHello @kapetr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user interface and experience for managing run model settings. It introduces new, modular UI components and refactors existing ones to provide a more intuitive and flexible way for users to configure model parameters and providers. The changes aim to streamline the interaction with agent settings and improve the overall usability of the application's configuration flows. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new UX for run model settings, enhancing the user interface with radio select components and dialogs for settings and model providers. The changes include refactoring and renaming components, adding new components for radio select and form action bars, and updating the settings agent in the Python SDK. The addition of a console log in rsc.tsx should be removed before merging.
There was a problem hiding this comment.
Code Review
This pull request introduces a new user experience for run model settings by refactoring several components to use a new RadioSelect component and a dialog-based approach. The changes are extensive and improve component structure and reusability. However, I've found several critical issues, including a repeated typo (setPositionReference instead of setReference) that will cause runtime errors, as well as some high-severity bugs like missing CSS class definitions. I've also included some suggestions for code style and best practices to enhance code quality.
Signed-off-by: Petr Kadlec <[email protected]>
There was a problem hiding this comment.
CSS rules for .fields and .buttons inside apps/beeai-ui/src/modules/form/components/FormRenderer.module.scss can be deleted.
| import classes from './FormActionBar.module.scss'; | ||
|
|
||
| interface Props { | ||
| isDisabled?: boolean; |
There was a problem hiding this comment.
I think isSubmitDisabled or something similar would be more descriptive.
| .root { | ||
| display: grid; | ||
| grid-template-columns: 1fr max-content; | ||
| align-items: center; |
There was a problem hiding this comment.
We can simplify the styles here removing the "align-items: center" with "block-size: rem(40px)" from .settings.
Signed-off-by: Petr Kadlec <[email protected]>
Closes #1182